Add FRF noise covariance calculation library #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
==========================================
+ Coverage 97.16% 97.20% +0.04%
==========================================
Files 31 31
Lines 11064 11140 +76
==========================================
+ Hits 10750 10829 +79
+ Misses 314 311 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsdillon
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Thanks @mwilensky768. This all looks basically fine, just a couple of minor suggestions
added 6 commits
October 16, 2024 11:18
jsdillon
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds some noise propagation functions for the fringe rate filter + coherent averaging steps.
I've added the basic functions that are demonstrated in the single baseline power spectrum notebook, though they've been modified here to be slightly more general since the notebook versions used notebook-specific info. This PR and the corresponding one on that repo should probably coordinate.
I still need to add unit tests and think I should add a wrapper that goes from ee + nn autos/crosses all the way to a pI time-time cov. per freq so that there is a clearly implemented "pipeline" somewhere, though maybe that should just live in another repo as part of actual pipeline code.