Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make refpol the one that doesn't change in cross_pol_phase_cal, as the docstring describes #976

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

jsdillon
Copy link
Member

No description provided.

@jsdillon jsdillon requested a review from tyler-a-cox August 30, 2024 18:03
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (192db21) to head (ead353a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #976   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          31       31           
  Lines       11064    11064           
=======================================
  Hits        10750    10750           
  Misses        314      314           
Flag Coverage Δ
unittests 97.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tyler-a-cox tyler-a-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for the fix @jsdillon

@jsdillon jsdillon merged commit 0529798 into main Aug 30, 2024
8 of 9 checks passed
@jsdillon jsdillon deleted the phase_cal_refpol branch August 30, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants