Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and fix NoSlowD for legacy versions (pre 1.21.4) #1882

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from

Conversation

Axionize
Copy link
Contributor

No description provided.

@Axionize Axionize requested a review from ManInMyVan December 15, 2024 20:00
@Axionize Axionize force-pushed the feat/noslowd-legacy-support branch from b586bc9 to cde2174 Compare December 15, 2024 20:00
Copy link
Contributor

@ManInMyVan ManInMyVan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a config option, and this needs to hook into where we update isSlowedByUsingItem again

@@ -23,7 +36,9 @@ public void onPredictionComplete(final PredictionComplete predictionComplete) {
ClientVersion client = player.getClientVersion();

// https://bugs.mojang.com/browse/MC-152728
if (client.isNewerThanOrEquals(ClientVersion.V_1_14_2) && client.isOlderThan(ClientVersion.V_1_21_4)) {
if (startedSprintingBeforeUse && client.isNewerThanOrEquals(ClientVersion.V_1_14_2) && client.isOlderThan(ClientVersion.V_1_21_4)) {
reward();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are allowed to sprint, don't reward

Suggested change
reward();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants