Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore placements if they have a cooldown #1853

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from

Conversation

SergioK29
Copy link
Contributor

TODO: CompensatedCooldown needs to be updated to support 1.21.3 cooldown keys also

TODO: CompensatedCooldown needs to be updated to support 1.21.3 cooldown keys also
@SamB440
Copy link
Contributor

SamB440 commented Dec 3, 2024

1.21.3 cooldown keys?

@SamB440 SamB440 added the status: review required The pull request is awaiting review label Dec 3, 2024
@SergioK29
Copy link
Contributor Author

@SamB440
Copy link
Contributor

SamB440 commented Dec 3, 2024

Won't the server just send the set cooldown packet for that? Why do we need to handle anything special?

@AoElite
Copy link
Collaborator

AoElite commented Dec 4, 2024

@SergioK29 Does this PR fix anything in game you've noticed before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: review required The pull request is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants