Added missing verbose for a few checks #1852
Open
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManInMyVan
requested changes
Dec 3, 2024
src/main/java/ac/grim/grimac/checks/impl/scaffolding/AirLiquidPlace.java
Outdated
Show resolved
Hide resolved
| if (flagAndAlert() && shouldModifyPackets() && shouldCancel()) { | ||
| double distance = NumberConversions.square(blockPos.getX() - player.x) + NumberConversions.square(blockPos.getY() - player.y) + NumberConversions.square(blockPos.getZ() - player.z); | ||
|
|
||
| if (flagAndAlert("against=" + placeAgainst + " type=" + place.getMaterial() + " dist=" + Math.sqrt(distance)) |
There was a problem hiding this comment.
why is distance included?
There was a problem hiding this comment.
why is distance included?
AirLiquidPlace has falsed in the past for me when the player places blocks particularly close to them.
Co-authored-by: ManInMyVan <[email protected]>
…Place.java Co-authored-by: ManInMyVan <[email protected]>
ManInMyVan
requested changes
Dec 9, 2024
src/main/java/ac/grim/grimac/checks/impl/scaffolding/FarPlace.java
Outdated
Show resolved
Hide resolved
| @@ -23,7 +24,10 @@ public void onBlockPlace(final BlockPlace place) { | |||
| StateType placeAgainst = player.compensatedWorld.getStateTypeAt(blockPos.getX(), blockPos.getY(), blockPos.getZ()); | |||
|
|
|||
| if (placeAgainst.isAir() || Materials.isNoPlaceLiquid(placeAgainst)) { // fail | |||
| if (flagAndAlert() && shouldModifyPackets() && shouldCancel()) { | |||
| double distance = NumberConversions.square(blockPos.getX() - player.x) + NumberConversions.square(blockPos.getY() - player.y) + NumberConversions.square(blockPos.getZ() - player.z); | |||
There was a problem hiding this comment.
I really don't think distance is necessary
There was a problem hiding this comment.
I really don't think distance is necessary
just include it anyways 🙏
AirLiquidPlace has falsed in the past for me when the player places blocks particularly close to them.
| @@ -39,7 +39,7 @@ public void onBlockPlace(final BlockPlace place) { | |||
| maxReach += Math.hypot(threshold, threshold); | |||
|
|
|||
| if (min > maxReach * maxReach) { // fail | |||
| if (flagAndAlert() && shouldModifyPackets() && shouldCancel()) { | |||
| if (flagAndAlert("dist=" + Math.sqrt(min)) && shouldModifyPackets() && shouldCancel()) { | |||
There was a problem hiding this comment.
The amount of decimals shown should be capped
There was a problem hiding this comment.
The amount of decimals shown should be capped
does grim have any easy util methods for this?
Co-authored-by: ManInMyVan <[email protected]>
…java Co-authored-by: ManInMyVan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.