Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy of bukkit Vector #1765

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from

Conversation

OOP-778
Copy link

@OOP-778 OOP-778 commented Oct 23, 2024

Draft for platform independent Grim

  • I'll post more things as I go

@OOP-778
Copy link
Author

OOP-778 commented Oct 23, 2024

Related to GrimAnticheat/GrimAPI#7

@jonesdevelopment
Copy link
Contributor

PacketEvents has their own implementation of Vector3f, Vector3i, Vector3d, etc.

@OOP-778
Copy link
Author

OOP-778 commented Oct 23, 2024

PacketEvents has their own implementation of Vector3f, Vector3i, Vector3d, etc.

They do but for us to use it, it requires major changes in the code since Vector3d is not mutable.

@OOP-778
Copy link
Author

OOP-778 commented Oct 23, 2024

I didn't want to break anything whilst moving hence I chose to keep bukkit vector but as a copy

@SamB440
Copy link
Contributor

SamB440 commented Oct 23, 2024

I would rather move to JOML

@SamB440
Copy link
Contributor

SamB440 commented Oct 23, 2024

Maybe it's bad shading a new math library in though

@OOP-778
Copy link
Author

OOP-778 commented Oct 23, 2024

Maybe it's bad shading a new math library in though

There's no point for two classes that are simple to shade a full on math library

@SamB440
Copy link
Contributor

SamB440 commented Oct 23, 2024

Also please don't make one giant pr, they should each be individual like this

@OOP-778
Copy link
Author

OOP-778 commented Oct 24, 2024

Also please don't make one giant pr, they should each be individual like this

To be fair it's not quite possible I mean this change might be but removing completely spigot & etc it has to be a single package.

@Axionize
Copy link
Contributor

If you have the chance to replace all the vector code with a new platform-independent implementation, please make it SIMD

@SamB440 SamB440 added the status: blocked The issue or pull request is blocked by something else label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked The issue or pull request is blocked by something else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants