-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy of bukkit Vector #1765
base: 2.0
Are you sure you want to change the base?
Copy of bukkit Vector #1765
Conversation
Related to GrimAnticheat/GrimAPI#7 |
PacketEvents has their own implementation of Vector3f, Vector3i, Vector3d, etc. |
They do but for us to use it, it requires major changes in the code since Vector3d is not mutable. |
I didn't want to break anything whilst moving hence I chose to keep bukkit vector but as a copy |
I would rather move to JOML |
Maybe it's bad shading a new math library in though |
There's no point for two classes that are simple to shade a full on math library |
Also please don't make one giant pr, they should each be individual like this |
To be fair it's not quite possible I mean this change might be but removing completely spigot & etc it has to be a single package. |
If you have the chance to replace all the vector code with a new platform-independent implementation, please make it SIMD |
Draft for platform independent Grim