Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch full autoblock and desync noslows #1757

Draft
wants to merge 2 commits into
base: 2.0
Choose a base branch
from

Conversation

ManInMyVan
Copy link
Contributor

@ManInMyVan ManInMyVan commented Oct 13, 2024

also patches via sword noslow

closes #1591
closes #727

@overkidding
Copy link
Contributor

Resets some item states also to legit players, sometimes it does not eats gapples or shoot bow arrows, should be fixed before merging in my opinion.

@ManInMyVan
Copy link
Contributor Author

Resets some item states also to legit players, sometimes it does not eats gapples or shoot bow arrows, should be fixed before merging in my opinion.

you can also disable it

@overkidding
Copy link
Contributor

Resets some item states also to legit players, sometimes it does not eats gapples or shoot bow arrows, should be fixed before merging in my opinion.

you can also disable it

the option to enable or disable it does not increase the fix quality, it should work always this does not, gives issues 85% of the times tested it in production with 15+ players and I was already getting tons of falses (i enabled flagging to test the mitigation and see if it was falsing).

@ManInMyVan
Copy link
Contributor Author

ManInMyVan commented Oct 17, 2024

Resets some item states also to legit players, sometimes it does not eats gapples or shoot bow arrows, should be fixed before merging in my opinion.

you can also disable it

the option to enable or disable it does not increase the fix quality, it should work always this does not, gives issues 85% of the times tested it in production with 15+ players and I was already getting tons of falses (i enabled flagging to test the mitigation and see if it was falsing).

Can I get a video of this happening?

@overkidding
Copy link
Contributor

Can I get a video of this happening?

Just use flagAndAlert() and try to fight in 1.8

@Regomy
Copy link

Regomy commented Oct 24, 2024

Hello, may i ask, your pr is better than #1467?

@overkidding
Copy link
Contributor

Hello, may i ask, your pr is better than #1467?

The #1467 contains generic packed based autoblock checks that i might think have already been patched by other ManInMyVan PR's.

This is for desync no slow and autoblocks, etc.

This might still "false" (falsely mitigate) due to the vanilla desync behavior (some of desyncs that autoblocks uses actually happen also in legit vanilla)

@ManInMyVan ManInMyVan force-pushed the fix/autoblock-and-noslow branch 2 times, most recently from 13ad59f to 7b0ae9b Compare October 27, 2024 17:12
@ManInMyVan ManInMyVan force-pushed the fix/autoblock-and-noslow branch from 7b0ae9b to 1a15242 Compare November 8, 2024 19:58
@Dg32z
Copy link
Contributor

Dg32z commented Nov 19, 2024

2024-11-19.12-49-11.mp4

@ManInMyVan
Copy link
Contributor Author

2024-11-19.12-49-11.mp4

seems to only happen at low fps (<20)

@ManInMyVan ManInMyVan marked this pull request as draft November 20, 2024 02:34
@Dg32z
Copy link
Contributor

Dg32z commented Nov 20, 2024

2024-11-19.12-49-11.mp4

seems to only happen at low fps (<20)

No, this can happen in any situation

@Dg32z
Copy link
Contributor

Dg32z commented Nov 20, 2024

2024-11-19.12-49-11.mp4

seems to only happen at low fps (<20)

You think so because I adjusted the fps and resolution to reduce the video's occupancy

@ManInMyVan
Copy link
Contributor Author

2024-11-19.12-49-11.mp4

seems to only happen at low fps (<20)

You think so because I adjusted the fps and resolution to reduce the video's occupancy

I think so because that's the only situation I could replicate it

@ManInMyVan ManInMyVan force-pushed the fix/autoblock-and-noslow branch from 5165270 to 3db1700 Compare November 24, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the bow noslow FDPClient bow noslow bypass
4 participants