Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MiniMessage And PlaceHolderAPI Support #1621

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from
Open

Add MiniMessage And PlaceHolderAPI Support #1621

wants to merge 1 commit into from

Conversation

ManInMyVan
Copy link
Contributor

@ManInMyVan ManInMyVan commented Jul 27, 2024 •
edited
Loading

also makes reload message customizable

closes #977
should close #1169

jonesdevelopment
jonesdevelopment suggested changes Jul 28, 2024
View reviewed changes
Copy link
Contributor

@jonesdevelopment jonesdevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something or are these dependencies not being relocated? Make sure they are relocated, as some server forks ship them by default, and we don't want incompatibilities with other plugins that aren't relocating adventure.

@ManInMyVan
Copy link
Contributor Author

Am I missing something or are these dependencies not being relocated? Make sure they are relocated, as some server forks ship them by default, and we don't want incompatibilities with other plugins that aren't relocating adventure.

We should already be shading adventure https://github.com/GrimAnticheat/Grim/blob/2.0/build.gradle.kts#L146

@ManInMyVan ManInMyVan changed the title Add MiniMessage Support Add MiniMessage And PlaceHolderAPI Support Jul 30, 2024
@ManInMyVan ManInMyVan mentioned this pull request Jul 30, 2024
Closed
@Anthony01M
Copy link
Contributor

not sure if I copied wrong but, console alert include what shouldn't be included, might want to find a way to strip them before this gets pulled; (this is before the PlaceHolderAPI Support, and doesn't seem like the PlaceHolderAPI Support commit even fixes this)
image

@ManInMyVan
Copy link
Contributor Author

not sure if I copied wrong but, console alert include what shouldn't be included, might want to find a way to strip them before this gets pulled; (this is before the PlaceHolderAPI Support, and doesn't seem like the PlaceHolderAPI Support commit even fixes this)
image

You definitely copied it wrong

@ManInMyVan ManInMyVan force-pushed the minimessage branch 2 times, most recently from abc1a28 to 54f1cb4 Compare October 27, 2024 18:48
@ManInMyVan ManInMyVan force-pushed the minimessage branch 2 times, most recently from 259cef7 to f59721a Compare November 29, 2024 19:11
@SamB440 SamB440 added the status: review required The pull request is awaiting review label Dec 1, 2024
@SamB440 SamB440 mentioned this pull request Dec 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonesdevelopment jonesdevelopment jonesdevelopment approved these changes

@SamB440 SamB440 SamB440 approved these changes

Assignees
No one assigned
Labels
status: review required The pull request is awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hoverable Alerts Support for PlacehodersAPI
4 participants
@ManInMyVan @Anthony01M @SamB440 @jonesdevelopment