Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BadPackets2 #1589

Closed
wants to merge 1 commit into from
Closed

Add BadPackets2 #1589

wants to merge 1 commit into from

Conversation

ManInMyVan
Copy link
Contributor

detects some bad keypearls and some switchitem noslows (full patch in #1469)

@overkidding
Copy link
Contributor

BadPackets2
Falses in 1.8 (testing in production) gettings spam flags

@xEcho1337
Copy link
Contributor

This can be bypassed by delaying the C09 to the next tick, also an heuristic check would be much better

@ManInMyVan
Copy link
Contributor Author

This can be bypassed by delaying the C09 to the next tick

I'm aware, I said some

@ManInMyVan
Copy link
Contributor Author

BadPackets2
Falses in 1.8 (testing in production) gettings spam flags

Replication steps?

@overkidding
Copy link
Contributor

overkidding commented Jul 29, 2024

BadPackets2
Falses in 1.8 (testing in production) gettings spam flags

Replication steps?

Just Fast switch items and click the ground fast

@ManInMyVan
Copy link
Contributor Author

BadPackets2
Falses in 1.8 (testing in production) gettings spam flags

Replication steps?

Just Fast switch items and click the ground fast

Could not replicate on vanilla or lunar 1.8.9, maybe send a video?

@ManInMyVan
Copy link
Contributor Author

BadPackets2
Falses in 1.8 (testing in production) gettings spam flags

Replication steps?

Just Fast switch items and click the ground fast

I think I fixed it, are you able to reproduce on 28b2a56?

@overkidding
Copy link
Contributor

BadPackets2
Falses in 1.8 (testing in production) gettings spam flags

Replication steps?

Just Fast switch items and click the ground fast

I think I fixed it, are you able to reproduce on 28b2a56?

I confirm that this has been fixed

@ManInMyVan
Copy link
Contributor Author

#1678

@ManInMyVan ManInMyVan closed this Aug 22, 2024
@ManInMyVan ManInMyVan deleted the bp2 branch August 22, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants