Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datanode/opensearch configuration beans #21082

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Nov 29, 2024

This opensearch configuration handling continues in the direction #21031 started.

The very same configuration handling pattern will be used for Trino.

image

Benefits of this handling:

  • Repeatable configuration builds, groundwork for immutable and read-only configuration
  • All configuration options are going through the same pipeline and data types => predictable code and locations instead of chaotic configuration through the whole datanode codebase.
  • Configuration can be written to temp directory, for each process run separately and independently (removes existing concurrency issues when restarting opensearch process)
  • Massively simplified certificates and security handling
  • Unified approach for JVM options, opensearch.yml properties and opensearch.keystore entries
  • Password secret completely removed from opensearch configuration, replaced by OTP
  • Removes configuration side-effects from opensearch process impl
  • Prepared to replace OpensearchConfigSync preflight check (misused to sync default opensearch config files)

/nocl

How Has This Been Tested?

Existing set of unit and integration tests

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora marked this pull request as ready for review December 2, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant