Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sorting events/alerts based on aggregation time range. #21044

Merged

Conversation

dennisoelkers
Copy link
Member

Description

Motivation and Context

This PR enables sorting alerts/events based on aggregation time range both in the front- and backend.

The sorting for this field needs to be created so that both timerange_start & timerange_end are taken into account.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers force-pushed the feat/sort-events-based-on-aggregation-time-range branch from aa7d303 to 8c1c92e Compare November 29, 2024 09:08
@dennisoelkers dennisoelkers marked this pull request as ready for review November 29, 2024 09:39
Copy link
Contributor

@janheise janheise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisoelkers dennisoelkers merged commit ef862a3 into master Dec 4, 2024
7 checks passed
@dennisoelkers dennisoelkers deleted the feat/sort-events-based-on-aggregation-time-range branch December 4, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants