Update to jackson 2.13

[patrickmann]

Upgrade to the current Jackson version 2.13.4, while keeping everything else unchanged (as much as possible).
https://github.com/Graylog2/graylog-plugin-enterprise/issues/3674

Details

• If configuration of ObjectMapper is modified after first usage, changes may or may not take effect, and configuration calls themselves may fail [link]. This behavior appears to have changed since version 2.9. It only affects a few tests which attempt to modify the mapper:
  graylog2-server/src/test/java/org/graylog/events/contentpack/facade/EventDefinitionFacadeTest.java
  graylog2-server/src/test/java/org/graylog/events/contentpack/facade/NotificationFacadeTest.java

• DateTimeFormatter now throws an exception for empty string, resulting in a JSON missing node that needs to be handled:
  graylog2-server/src/main/java/org/graylog/plugins/beats/Beats2Codec.java

• Jackson 2.11 changed the default DateTime formatting for timezone offset to hh:mm instead of hhmm [link]. We need to explicitly set the legacy format in the ObjectMapper.
  graylog2-server/src/main/java/org/graylog2/shared/bindings/providers/ObjectMapperProvider.java
  graylog2-server/src/test/java/org/graylog/plugins/views/migrations/V20200204122000_MigrateUntypedViewsToDashboardsTest.java
  graylog2-server/src/test/java/org/graylog2/jackson/MongoJodaDateTimeSerializerTest.java
  graylog2-server/src/test/java/org/graylog2/jackson/MongoZonedDateTimeSerializerTest.java

• Jackson no longer includes Joda date/time by default. The Joda module needs to be explicitly registered:
  graylog2-server/src/test/java/org/graylog2/plugin/MessageSummaryTest.java

/jenkins-pr-deps Graylog2/graylog-plugin-enterprise#4099,Graylog2/graylog-plugin-enterprise-integrations#902

[thll]

• DateTimeFormatter now throws an exception for empty string, resulting in a JSON missing node that needs to be handled:
  graylog2-server/src/main/java/org/graylog/plugins/beats/Beats2Codec.java

I don't think that DateTimeFormatter is the culprit here, but rather ObjectMapper.readTree(input) not returning null for empty input anymore: FasterXML/jackson-databind#2211.

[thll]

Are you sure, that we still need the workaround? I think we can remove this dependency.

[patrickmann]

We don't. I was just updating versions without looking any deeper.
Removed it.

[patrickmann]

Getting a dependency error running the integration tests, so I am reverting the reversion of scala 3.

com.fasterxml.jackson.databind.JsonMappingException: Scala module 2.10.5 requires Jackson Databind version >= 2.10.0 and < 2.11.0

[bernd]

@patrickmann Is this a runtime dependency, or can we put it into the test scope?

The stack trace in the test output seems to be rooted in the rest-assured dependency, a testing library.

The jackson-module-scala_3 dependency should also be present in the jackson-bom now. That means we don't need the hardcoded <version> tag for it.

[mpfz0r]

• DateTimeFormatter now throws an exception for empty string, resulting in a JSON missing node that needs to be handled:
  graylog2-server/src/main/java/org/graylog/plugins/beats/Beats2Codec.java

I don't think that DateTimeFormatter is the culprit here, but rather ObjectMapper.readTree(input) not returning null for empty input anymore: FasterXML/jackson-databind#2211.

Hah, so they changed it from throwing an exception to returning null and then to returning an empty node object?

[bernd]

See: #13541 (comment)

[mpfz0r]

LGTM 👍

[bernd]

The jackson-bom got bumped to 2.13.4.20221013 to fix a jackson-databind security issue: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.13#micro-patches. Let's update to that version. 🙂

[mpfz0r]

Jackson, a gift that keeps on giving :-/