Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url shortener #125

Merged
merged 26 commits into from
Jul 16, 2023
Merged

Url shortener #125

merged 26 commits into from
Jul 16, 2023

Conversation

SanderGi
Copy link
Member

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@SanderGi
Copy link
Member Author

Relies on GooeyAI/gooey-gui#2

@SanderGi
Copy link
Member Author

view count displays like this when the url has been shortened with Gooey url shortener:
image

@SanderGi
Copy link
Member Author

image

@SanderGi SanderGi requested a review from devxpy July 12, 2023 06:40
SanderGi and others added 7 commits July 12, 2023 21:49
@devxpy devxpy merged commit 616e185 into master Jul 16, 2023
@devxpy devxpy deleted the url_shortener branch September 23, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants