Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: events overhaul #745

Merged
merged 31 commits into from
May 17, 2024
Merged

fix: events overhaul #745

merged 31 commits into from
May 17, 2024

Conversation

garrettladley
Copy link
Member

@garrettladley garrettladley commented May 7, 2024 •
edited
Loading

  • update schema
  • make weekly / biweekly / monthly mutually exclusive in proto

@garrettladley garrettladley linked an issue May 7, 2024 that may be closed by this pull request
fix: events #669
Closed
This was linked to issues May 7, 2024
feat: private events #701
Closed
fix: duplicate event series route #668
Closed
Events: Address Comments #388
Closed
@alderwhiteford
Copy link
Collaborator

alderwhiteford commented May 7, 2024 •
edited
Loading

One small comment, we may want to have a const variable that we can hard cap a termination date if people try to set something beyond it

@garrettladley garrettladley marked this pull request as ready for review May 11, 2024 19:06
@garrettladley garrettladley requested review from a team and DOOduneye and removed request for a team May 11, 2024 19:06
DOOduneye
DOOduneye suggested changes May 12, 2024
View reviewed changes
Copy link
Contributor

@DOOduneye DOOduneye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work with reimagining events

backend/config/calendar.go Show resolved Hide resolved
@garrettladley
Copy link
Member Author

garrettladley commented May 13, 2024 •
edited
Loading

running into issues mapping structs with fields of type time.Time to other structs with time.Time.
function utilities.MapRequestToModel. Opened issue here

@garrettladley garrettladley merged commit cf1e04e into main May 17, 2024
5 checks passed
@garrettladley garrettladley deleted the 669-fix-events branch May 17, 2024 03:59
@garrettladley garrettladley mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alderwhiteford alderwhiteford alderwhiteford left review comments

@DOOduneye DOOduneye DOOduneye requested changes

Assignees

@garrettladley garrettladley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: private events fix: events fix: duplicate event series route Events: Address Comments
3 participants
@garrettladley @alderwhiteford @DOOduneye