working radio button mapping, ignore empty non-required fields

package.json

@@ -41,7 +41,7 @@
     "tsup": "^8.2.4",
     "turbo": "^2.0.14",
     "typescript": "^5.5.4",
-    "vitest": "^2.0.5",
+    "vitest": "^2.1.2",
     "vitest-mock-extended": "^2.0.0"
   }
-}
+}

packages/forms/src/documents/pdf/generate.ts

@@ -1,4 +1,9 @@
-import { PDFDocument, type PDFForm } from 'pdf-lib';
+import {
+  PDFDocument,
+  PDFName,
+  createPDFAcroFields,
+  type PDFForm,
+} from 'pdf-lib';
 
 import { Result } from '@atj/common';
 import { type FormOutput } from '../../index.js';
@@ -119,14 +124,21 @@ const setFormFieldData = (
       const field = form.getRadioGroup(fieldName);
       field.select(fieldValue);
     } catch (error: any) {
-      console.error(
-        `error setting radio field: ${fieldName}: ${error.message}`
-      );
-      const field = form.getCheckBox(fieldName);
-      if (fieldValue) {
-        field.check();
+      // This logic should work even if pdf-lib misidentifies the field type
+      // TODO: radioParent should contain the name, not the id
+      const [radioParent, radioChild] = fieldValue.split('.');
+      if (radioChild) {
+        // TODO: resolve import failure when spaces are present in name, id
+        const radioChildWithSpace = radioChild.replace('_', ' ');
+        const field = form.getField(fieldName);
+        const acroField = field.acroField;
+        acroField.dict.set(PDFName.of('V'), PDFName.of(radioChildWithSpace));
+        const kids = createPDFAcroFields(acroField.Kids()).map(_ => _[0]);
+        kids.forEach(kid => {
+          kid.dict.set(PDFName.of('AS'), PDFName.of(radioChildWithSpace));
+        });
       } else {
-        field.uncheck();
+        // do nothing
       }
     }
   } else if (fieldType === 'Paragraph' || fieldType === 'RichText') {

packages/forms/src/documents/pdf/parsing-api.ts

@@ -54,7 +54,7 @@ const RadioGroupOption = z.object({
 });
 
 const RadioGroup = z.object({
-  // id: z.string(),
+  id: z.string(),
   component_type: z.literal('radio_group'),
   legend: z.string(),
   options: RadioGroupOption.array(),
@@ -238,7 +238,7 @@ export const processApiResponse = async (json: any): Promise<ParsedPdf> => {
         pagePatterns[element.page] = (pagePatterns[element.page] || []).concat(
           radioGroupPattern.id
         );
-        /*
+
         parsedPdf.outputs[radioGroupPattern.id] = {
           type: 'RadioGroup',
           name: element.id,
@@ -252,7 +252,6 @@ export const processApiResponse = async (json: any): Promise<ParsedPdf> => {
           value: '',
           required: true,
         };
-        */
       }
       continue;
     }

packages/forms/src/pattern.ts

@@ -87,6 +87,15 @@ export const validatePattern = (
   }
   const parseResult = patternConfig.parseUserInput(pattern, value);
   if (!parseResult.success) {
+    if ('required' in pattern.data) {
+      if (pattern.data.required === false && !value) {
+        console.log('Parse result failed for blank input that is not required');
+        return {
+          success: true,
+          data: value,
+        };
+      }
+    }
     return {
       success: false,
       error: parseResult.error,