Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: implement more fine grained permission checks #416

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: implement more fine grained permission checks #416

wants to merge 3 commits into from

Conversation

DavideIadeluca
Copy link
Member

@DavideIadeluca DavideIadeluca commented Nov 10, 2024 •
edited
Loading

Fixes #393

Changes proposed in this pull request:

  • Introduce new dedicated permissions for hiding
  • Introduces new permissions checks for deleting

Reviewers should focus on:
No security vulnerabilities are introduced in DeleteFileHandler & FilePolicy

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@DavideIadeluca DavideIadeluca self-assigned this Nov 10, 2024
@DavideIadeluca DavideIadeluca changed the title fix: use more fine grained permission checks fix: implement more fine grained permission checks Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DavideIadeluca DavideIadeluca

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Members cannot delete their own files
2 participants
@DavideIadeluca @StyleCIBot