Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add food-101 recipe #194

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Add food-101 recipe #194

merged 1 commit into from
Jan 27, 2022

Conversation

Chandu-4444
Copy link
Contributor

@Chandu-4444 Chandu-4444 commented Jan 25, 2022

I've added food-101 to the RECIPES

Ref: #153

@lorenzoh
Copy link
Member

Have you tested loading this into a data container and can you check that checkblock(getobs(data, 1), blocks) is true?

@Chandu-4444
Copy link
Contributor Author

Oh, I forgot about tests. I'll check and will update the tests.

@lorenzoh
Copy link
Member

You don't need to write test cases for this, just test it manually. Unfortunately, we can't test every dataset recipe all the time since then CI would have to download every dataset (and just this one is a few GB I think)

@Chandu-4444
Copy link
Contributor Author

Okay, I'll test it manually and will update it here then 👍

@Chandu-4444
Copy link
Contributor Author

Have you tested loading this into a data container and can you check that checkblock(getobs(data, 1), blocks) is true?

Yeah, it returned true.

@lorenzoh
Copy link
Member

Thanks for checking!

@lorenzoh lorenzoh merged commit 486135d into FluxML:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants