-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use "gtk3" key to avoid conflict with QGtkStyle from Qt upstream #150
Conversation
This change breaks the theming with all the QT apps I have tried to run on Gnome :/ (lyx, vlc and makemkv for now) Is that intended? How are we supposed to get the "good looking" theming? I have seen you deprecated the project, but I am not sure about what to use instead :/ Thanks a lot |
This change was intended to avoid using QGnomePlatform by default over QGtkStyle from Qt. Both use "gtk3" as a key to load the plugin, but we were picked first automatically thanks to alphabetical order. You can still use QGnomePlatform if you want to by just setting |
I thought QGtkStyle was dead long time ago... and the code that I have found was last touched in 2017: Is there anything newer? If not... why prefer to go back to the old gtk2 theme over this? Even if both are deprecated... this looks at least more "updated" than the former I guess in downstream packaging we can now install a env.d file to set the variable to mimic the old behavior (as people installing qgnomeplatform will expect it to get used without more manual intervention for every user) |
Sorry, I meant QGtk3Theme. Looks I've been using the name wrongly all over the places. This one: https://github.com/qt/qtbase/tree/dev/src/plugins/platformthemes/gtk3 |
I have it installed for qt5 but, for some reason, it doesn't seem to be used automatically :/ I need to launch all the apps using QT_STYLE_OVERRIDE=adwaita (and with adwaita-qt installed) to get the right theming on GNOME |
Hello, I have tried to suggest people to use the env variable but, then, that looks to collide with people using KDE. Is there a way to get the variable set only on GNOME setups? Thanks |
You can check whether |
I will see where to export it globally then, it seems under xinitrc.d stuff we have similar scripts for conditionally changing things. Thanks a lot ! |
No description provided.