Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window borders #70

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix window borders #70

merged 1 commit into from
Jun 18, 2024

Conversation

grulja
Copy link
Contributor

@grulja grulja commented Jun 18, 2024

Alternative solution to #69.

@grulja grulja mentioned this pull request Jun 18, 2024
@bertini97
Copy link
Contributor

Thank you for taking the time to look into this. This commit produces the following on my end:

Schermata del 2024-06-18 11-07-33

There are grey rectangles coming out the window at the bottom; when I have time I'll look into why this happens. Also, without antialiasing, at around menubar height, the rounded rectangle used for the title bar leaks in the window border.

@grulja
Copy link
Contributor Author

grulja commented Jun 18, 2024

Thanks for testing, I didn't notice this as I was testing in Weston with a small window size and running Wireshark it didn't fit there completely so I didn't see it. Trying an app with a smaller window I can reproduce and fixed it now.

@grulja
Copy link
Contributor Author

grulja commented Jun 18, 2024

Can you please check if it works with antialising now?

@bertini97
Copy link
Contributor

It works!

@grulja grulja merged commit f40f31d into main Jun 18, 2024
5 checks passed
@grulja grulja deleted the window-borders branch June 18, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants