chore: improve track api

FeatureProbe · Mar 1, 2023 · 590faf9 · 590faf9
1 parent 01429ad
commit 590faf9
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 13 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/rust-uniffi/Cargo.toml b/rust-uniffi/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "fp-mobile-uniffi"
-version = "2.0.1"
+version = "2.0.2"
 edition = "2021"
 
 [lib]

diff --git a/rust-uniffi/src/featureprobe.udl b/rust-uniffi/src/featureprobe.udl
@@ -20,8 +20,7 @@ interface FeatureProbe {
     string json_value([ByRef] string key, string default_value);
     FPJsonDetail json_detail([ByRef] string key, string default_value);
 
-    void track([ByRef] string event);
-    void track_value([ByRef] string event, double value);
+    void track([ByRef] string event, optional double? value = null);
 };
 
 interface FPUser {

diff --git a/rust-uniffi/src/lib.rs b/rust-uniffi/src/lib.rs
@@ -111,12 +111,8 @@ impl FeatureProbe {
         }
     }
 
-    fn track(&self, event: &str) {
-        self.core.track_event(event, None);
-    }
-
-    fn track_value(&self, event: &str, value: f64) {
-        self.core.track_event(event, Some(value));
+    fn track(&self, event: &str, value: Option<f64>) {
+        self.core.track_event(event, value);
     }
 
     fn new_for_test(toggles: String) -> Self {

diff --git a/rust-uniffi/tests/bindings/test.kts b/rust-uniffi/tests/bindings/test.kts
@@ -15,4 +15,4 @@ val is_true = fp_for_test.boolValue("toggle_1", false)
 assert(is_true == true)
 
 fp_for_test.track("event")
-fp_for_test.trackValue("eventWithValue", 1.0)
+fp_for_test.track("eventWithValue", 1.0)
diff --git a/rust-uniffi/tests/bindings/test.swift b/rust-uniffi/tests/bindings/test.swift
@@ -19,5 +19,5 @@ let is_true = fp2.boolValue(key: "toggle_1", defaultValue: false)
 assert(is_true == true);
 
 fp2.track(event: "event")
-fp2.trackValue(event: "eventWithValue", value: 1.0)
+fp2.track(event: "eventWithValue", value: 1.0)
 
diff --git a/sdk-android/publish_aar.gradle b/sdk-android/publish_aar.gradle
@@ -12,7 +12,7 @@ task androidSourcesJar(type: Jar) {
 ext {path=
     PUBLISH_GROUP_ID = 'com.featureprobe'
     PUBLISH_ARTIFACT_ID = 'client-sdk-android'
-    PUBLISH_VERSION = '2.0.1' // update this version when release
+    PUBLISH_VERSION = '2.0.2' // update this version when release
 }
 
 ext["signing.keyId"] = System.getProperty("SIGN_KEYID")

diff --git a/sdk-ios/ObjcFeatureProbe.swift b/sdk-ios/ObjcFeatureProbe.swift
@@ -60,6 +60,18 @@ public final class OcFeatureProbe: NSObject {
         let d = fp.jsonDetail(key: key, defaultValue: defaultValue)
         return OFpJsonDetail(detail: d)
     }
+
+    @objc public func track(event: String) {
+        fp.track(event: event)
+    }
+
+    @objc public func track(event: String, value: Double) {
+        fp.track(event: event, value: value)
+    }
+
+    @objc public func close() {
+        fp.close()
+    }
 
 }