Test behavior of reading Instant and Duration from float. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to document the current behavior of those conversions.
toddjonker
commented
Oct 10, 2018
| * https://github.com/FasterXML/jackson-databind/issues/2141 | ||
| */ | ||
| @Test | ||
| public void testDeserializationAsFloatEdgeCase08() throws Exception |
There was a problem hiding this comment.
Edge cases 8-11 (in both files) use inputs just big enough to be demonstrably slow. On my MacBook they take about 8-17 seconds, slow enough to run all the time for the brief period until #84 (or similar) are merged. At that point I recommend adding low timeouts (maybe <100ms) to ensure good performance.
This was referenced Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to document the current behavior of those conversions.
This is in response to issues identified in #84 so as to prevent that fix from altering current behavior.