-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed mapping failure when private
companion object
is named
#438
Conversation
You can find CLA document here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and the process is usually so that you will print the document, fill in name and other fields, sign; then scan it (or take a photo with phone), and finally send that to |
Also: while this looks like a relatively simple fix, it might be safer against 2.13 branch, just in case. @dinomite WDYT? |
@cowtowncoder I think I probably could have done it, so please check. |
a4338ba
to
73ba479
Compare
@dinomite @cowtowncoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'll get this merged shortly.
private
companion object
is nammed.private
companion object
is named
quick note: thank you everyone for handling this quickly; I filed the CLA in the meantime and will update release notes (https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.13/ and release-notes/VERSION-2.x) |
@cowtowncoder Thanks for getting the notes! |
Currently, when retrieving a
companion object
from afield
, the name is used for comparison.jackson-module-kotlin/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinValueInstantiator.kt
Line 74 in 244b27f
On the other hand, you can name the
companion object
as follows.In this case, the field name in the compilation result will not be
Companion
.This causes the mapping to fail.
We fixed this in PR.
Question
I would like to submit a
CLA
, but is it enough to fill inYour name
andEmail
?Also, where should I submit it?
I'm not familiar with English or submitting the
CLA
, so I don't know what to do.If you could tell me how to do it, I would be very grateful.
Thank you.