Fixed issue #130 Default Parameter Values when JSON value is null #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, change is in a very long and quite complicated method, but since there is a unit test I trust it works as expected :) Thank you for contributing this! |
cowtowncoder
pushed a commit
that referenced
this pull request
Oct 26, 2019
This was referenced Oct 26, 2019
|
Any idea of the next release date ? |
|
No fixed date, but I hope to release 2.10.1 within next 2 weeks or so: many fixes, just want to optimize to include all fixes in-flight. @apatrida anything to include from kotlin side, before 2.10.1? It's one of components I want to sync with; the other being some module-info cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Kotlin Default Parameter Values when JSON value is null and Kotlin parameter type is Non-Nullable #130
In this case,
paramDef.isOptionalreturns true if we have default parameters. Then we do not setnullto these parameters, we have to use the default values.