Fix quote of # character in strict mode, fix #270 #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have just sent Contributor Agreement |
|
Sounds good, received CLA, hoping to review soon. Just one request: could you rebase this against 2.13; |
…ments are disabled. Quote only the first column, fix FasterXML#270
kdebski85
force-pushed
the
do_not_quote_comments_when_they_are_disabled
branch
from
9df3797
to
ee77287
Compare
|
Rebase to 2.13 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not quote with strict quoting when line starts with #, but comments are disabled. Quote only the first column, fix #270