-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should not quote with strict quoting when line starts with #
but comments are disabled
#270
Labels
Comments
kdebski85
pushed a commit
to kdebski85/jackson-dataformats-text
that referenced
this issue
May 19, 2021
…ments are disabled. Quote only the first column, fix FasterXML#270
Additionally, in strict mode '#' should only add quotes if it is used in the first column. When it used in any other column, quotes are not needed. |
fyi, tatu is away until next week, so you may have to wait a few days. |
kdebski85
pushed a commit
to kdebski85/jackson-dataformats-text
that referenced
this issue
May 28, 2021
…ments are disabled. Quote only the first column, fix FasterXML#270
cowtowncoder
pushed a commit
that referenced
this issue
May 28, 2021
…ments are disabled. Quote only the first column, fix #270 (#271) Co-authored-by: Krzysztof Debski <[email protected]>
cowtowncoder
changed the title
[jackson-dataformat-csv] Should not quote with strict quoting when line starts with #, but comments are disabled
Should not quote with strict quoting when line starts with May 28, 2021
#
but comments are disabled
cowtowncoder
added a commit
that referenced
this issue
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When STRICT_CHECK_FOR_QUOTING is enabled and withoutComments() is used, Jackson should not escape strings starting with "#"
The record contains a single string field with value #abc.
Expected:
#abc is written to CSV file
Actual:
"#abc" is written to CSV file
In CsvEncoder::_needsQuotingStrict "(c == '#' && i == 0)" should be checked only when comments are enabled.
The text was updated successfully, but these errors were encountered: