Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test case for issue #339 #340

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Add failing test case for issue #339 #340

merged 1 commit into from
Sep 13, 2022

Conversation

willsoto
Copy link
Contributor

See #339 for more info

@cowtowncoder
Copy link
Member

cowtowncoder commented Sep 11, 2022

Hmmh. As per my comment on #339, I am NOT 100% sure this is a valid test. In particular, it will not add any sync or file header beyond initial header since the output is considered a single logical stream.
But I guess I can just merge it and we can determine validity over time, at least there is a reproduction.

One thing I do need before merging (if not already done) is CLA, from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual method is to print it, fill & sign, scan/photo, email to info at fasterxml dot com.
Once I get that I can merge the test case. Thank you!

@willsoto
Copy link
Contributor Author

I'm more than happy to tweak the test case as necessary.

I wasn't quite sure what your intention was with that comment - I thought you may have just been positing one way it could work.

@cowtowncoder
Copy link
Member

@willsoto Right, my comment was bit ambiguous. My guess is that this has no chance of working as things are; but what I am not sure of is as to whether this should be the way to use API. To know that I'd need to spend some time again reading Avro spec wrt file encoding. Specifically about whether Avro has a "Stream" concept distinct from Arrays of things. If so, it would conceptually match Jackson's SequenceWriter.
And from that, whether there is additional sync/marker requirement between elements -- it looks like there is, judging by exception message. That would require solving; Jackson does actually have the concept of "Root Value Separator"s which might work. Not exactly as-is, since separator is assumed to be String. But... maybe with some tweaks.

Since I don't quite know if this is valid or not, I'd be happy to include it under failing/ for storage, being easier to find whenever someone (myself or something else) has time to dig in and see if there's a solution.

@willsoto
Copy link
Contributor Author

@cowtowncoder CLA sent.

@cowtowncoder cowtowncoder merged commit 3ece265 into FasterXML:2.14 Sep 13, 2022
@willsoto willsoto deleted the 339-failing-test branch September 13, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants