Add failing test for #4047 #4049
Conversation
JooHyukKim
changed the title
ObjectMapper.valueToTree ignores SerializationFeature.WRAP_ROOT_VALUE)
JooHyukKim
changed the title
| } | ||
|
|
||
|
|
||
| public void testTreeToValue() throws Exception |
| */ | ||
| UNWRAP_MAPPER.readTree(WRAPPED_EVENT_JSON); | ||
| UNWRAP_MAPPER.readTree(UNWRAPPED_EVENT_JSON); | ||
| } |
There was a problem hiding this comment.
When DeserializationFeature.UNWRAP_ROOT_VALUE is enabled, readTree() works like
UNWRAP_MAPPER.readValue(WRAPPED_EVENT_JSON, JsonNode.class);But, should it?
There was a problem hiding this comment.
This is tricky: my thinking all along has been that no, WRAP/UNWRAP related to POJOs and should not affect JsonNode: JsonNode (tree model in general) being used to represent JSON exactly as is, with no (or minimal) translations: no naming conventions, no ignorals... and hence no wrapping/unwrapping.
But then again some users disagree, and maybe more importantly, implementation may be such that wrapping/unwrapping occurs outside control of (de)serializer being used.
I suspect this could actually be one reason for handling of:
mapper.readTree(source);
mapper.readValue(source, JsonNode.class);
to possibly differ.
JooHyukKim
changed the title
…alueToTree-will-ignore-the-configuration-SerializationFeature.WRAP_ROOT_VALUE-
|
Could this be merged with PR #4050 ? |
|
@cowtowncoder sure. Will do. Plain merge or exclude some? |
Maybe copy ones relevant to initial case, Maybe follow-up issue/PR for |
|
EDITED |
Closingas per notes above #4049 (comment) |
JooHyukKim
deleted the
4047-ObjectMapper.valueToTree-will-ignore-the-configuration-SerializationFeature.WRAP_ROOT_VALUE-
branch
Reproduces #4047