Fix #3533 #3558
Merged
Fix #3533 #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to underlying AsArrayTypeDeserializer
|
Ok. I wish I remembered more of details here, but I assume you have a better understanding of this than I do, so will merge. :) Thank you for providing the fix and your patience! |
|
Oh. Forgot to ask for one thing @fxshlein -- this really could use a unit test. I already merge the PR but if you could at all provide a test that'd be great. That would guard against possibility of regression, as well as show intended usage beyond explanation (explanation makes sense but actual test is always better). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This delegates absent value handling for EXTERNAL_PROPERTY to the underlying AsArrayTypeDeserializer, as described in #3533.