Pull request for solving issue #400 #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocals after application shutdown. Keeps a list of softly referenced BufferRecyclers and weakly references from ThreadLocals.
…antially with every SoftReferences clearing by gc, a small leak. Solved by using a ReferenceQueue. Additionally added more doc.
…d from ThreadLocals, to a Set referencing the SoftRefs referenced from ThreadLocals. This saves the WeakRefs, less complex, and the set provides faster, O(1) add and remove operations. Shutdown iterates and clears the Set, soguarded by a lock.
… by a feature and static method. Factored out new machinery into separate class, only instantiated if enabled.
…ency; added newline at end of file
…factory instance level, by request of Tatu.
… to be unmanagable. It can now only be enabled during classloading with system property com.fasterxml.jackson.core.use_releasable_thread_local_buffers=true
# Conflicts: # src/main/java/com/fasterxml/jackson/core/JsonFactory.java
Added releaseBuffers method, called from shutdown. Improved javadoc.
|
@jborgers Looks good: I will refactor bits and pieces but that should be easy enough. Just need bit of uninterrupted time to piece it together, and can perhaps do some performance testing for fun too. |
cowtowncoder
added a commit
that referenced
this pull request
Apr 9, 2018
|
Thank you again -- ended up integrated manually, so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for solving issue #400: BufferRecyclers are not released on shutdown of the application.
Can't automatically merge. This fork started in Sep 2017 so behind of base fork.