Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support Gymnasium v1.0 #610

Merged
merged 10 commits into from
Aug 18, 2024

Conversation

pseudo-rnd-thoughts
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented Aug 9, 2024

This PR works to update the project to Support Gymnasium v1.0

In part it adds testing using check_env for all the registered highway-env environments, which uncovered a couple of issues that are fixed (primarily in exit env and the multi-agent wrapper)

As a result of removing the plugin system requiring that users import highway_env to register the environments, I have bumped the project version to 2.0.0, this might be unnecessary and we could use 1.10.0

Copy link
Member

@LucasAlegre LucasAlegre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@eleurent
Copy link
Collaborator

LGTM too, thanks Mark!

@eleurent eleurent merged commit 9db00e0 into Farama-Foundation:master Aug 18, 2024
6 checks passed
@eleurent eleurent mentioned this pull request Aug 18, 2024
@eleurent
Copy link
Collaborator

Since this was merged, the upload to PyPi is now failing (e.g. for release 1.10) with

ERROR InvalidDistribution: Metadata is missing required fields: Name.

see https://github.com/Farama-Foundation/HighwayEnv/actions/runs/10442911768/job/28915719241

Do you have an idea where this Name metadata should go, by any chance?

@pseudo-rnd-thoughts
Copy link
Member Author

Since this was merged, the upload to PyPi is now failing (e.g. for release 1.10) with

ERROR InvalidDistribution: Metadata is missing required fields: Name.

see https://github.com/Farama-Foundation/HighwayEnv/actions/runs/10442911768/job/28915719241

Do you have an idea where this Name metadata should go, by any chance?

The problem is that the release is using setup.py to install rather than python -m build.
setup.py install has been deprecated so I made #615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants