Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade asm to 9.7 to support java 23 #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0utplay
Copy link

@0utplay 0utplay commented Nov 18, 2024

Hi,
I wanted to update ASM to 9.7 because otherwise paperweight is failing (its using TR).
I am not sure how to properly test this change as I am not that familiar with TR so I just ran the unit / integration tests.

Caused by: java.lang.RuntimeException: error analyzing X/WorldRegion.class from X
	at net.fabricmc.tinyremapper.TinyRemapper.analyze(TinyRemapper.java:604)
	at net.fabricmc.tinyremapper.TinyRemapper.access$400(TinyRemapper.java:71)
	at net.fabricmc.tinyremapper.TinyRemapper$2.visitFile(TinyRemapper.java:553)
	at net.fabricmc.tinyremapper.TinyRemapper$2.visitFile(TinyRemapper.java:549)
	at java.base/java.nio.file.Files.walkFileTree(Files.java:2810)
	at java.base/java.nio.file.Files.walkFileTree(Files.java:2881)
	at net.fabricmc.tinyremapper.TinyRemapper.readFile(TinyRemapper.java:549)
	at net.fabricmc.tinyremapper.TinyRemapper.access$200(TinyRemapper.java:71)
	at net.fabricmc.tinyremapper.TinyRemapper$1$1.get(TinyRemapper.java:521)
	at net.fabricmc.tinyremapper.TinyRemapper$1$1.get(TinyRemapper.java:517)
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1812)
	... 3 more
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 67
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:200)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:180)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:166)
	at net.fabricmc.tinyremapper.TinyRemapper.analyze(TinyRemapper.java:602)
	... 13 more

build.gradle Outdated Show resolved Hide resolved
@0utplay 0utplay requested a review from modmuss50 November 18, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants