Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support per-element-metadata #41

Draft
wants to merge 22 commits into
base: dev
Choose a base branch
from
Draft

Support per-element-metadata #41

wants to merge 22 commits into from

Conversation

NebelNidas
Copy link
Member

@NebelNidas NebelNidas commented Sep 17, 2023 •
edited
Loading

With this, we can support:

  • Enigma's access modifiers,
  • TSRG2's is_static info and
  • Proguard's line numbers.

It's also needed for future revisions of the Tiny format, which will most likely allow for attaching arbitrary metadata.

Depends on #29 and #30.

@NebelNidas NebelNidas force-pushed the per-element-metadata branch 3 times, most recently from 70659b9 to 8c17b23 Compare September 20, 2023 09:28
@NebelNidas NebelNidas mentioned this pull request Sep 20, 2023
Draft
@liach
Copy link

liach commented Sep 23, 2023

I recommend splitting the new visitor APIs from #29 and #30.

@NebelNidas NebelNidas force-pushed the per-element-metadata branch 2 times, most recently from c0acf94 to 2b22fbb Compare October 1, 2023 15:16
@NebelNidas
Move Tiny properties to separate class
4c72e69
@NebelNidas
Remove duplicate escaped-names property
c00c98b
@NebelNidas
Prevent instantiation of TinyProperties class
07238f9
@NebelNidas
Create cross-format StandardProperties class
7e1f237 
- Now supports `component` intermediary counter
- Removes some hardcoded values
- Tiny v1 now supports reading arbitrary metadata (prefixed with `#`)
@NebelNidas
Fix checkstyle
7709261
@NebelNidas
Add missing license headers
98f04f7
@NebelNidas
Fix Tiny v1 metadata detection
14d047d
@NebelNidas
Don't read properties from non-applicable formats
76c2a89
@NebelNidas
Use builder for standard properties
3348d45
@NebelNidas
Consolidate builder functionality into StandardPropertyImpl
2b4ead1
@NebelNidas
Properly handle multiple metadata entries with same key
426bfb0
@NebelNidas
Fix MetadataEntry's equals and hashCode methods
1bc07fb
@NebelNidas
Always override existing metadata entries, use Map under the hood
d6f7a4d
@NebelNidas
Remove unused imports
a22d759
@NebelNidas
Revert to previous design
39e6781 
This reverts commit 2a82c6e.
@NebelNidas
Expose MetadataEntrys instead of Map.Entry<String, String>
bea6a69
@NebelNidas
Use NEEDS_UNIQUENESS flag instead of overrideExisting
803986f
@NebelNidas
Add new placeholder MetadataEntry interface
2b2b6a2
@NebelNidas
Add tests
a7d1bf7
@NebelNidas
Add per-element-metadata
cbc1a0c
@NebelNidas NebelNidas force-pushed the per-element-metadata branch from 2b22fbb to cbc1a0c Compare October 1, 2023 15:21
@NebelNidas NebelNidas mentioned this pull request Oct 10, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liach liach liach requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NebelNidas @liach