Improve exception displaying #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liach
reviewed
May 6, 2021
| } | ||
|
|
||
| for (Throwable ec : e.getSuppressed()) { | ||
| appendException(errorMessage, prefix + prefixAppend, Utils.BUNDLE.getString("prompt.exception.suppressed"), ec); |
There was a problem hiding this comment.
Should these translation messages be removed in case these are their only usages?
There was a problem hiding this comment.
Probably, the Java printStackTrace doesn't bother with localizing them and it's somewhat counterproductive considering the stack trace being for devs
There was a problem hiding this comment.
I think I'll leave the lang string cleanup for later.
modmuss50
approved these changes
May 6, 2021
liach
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the issue in #67 somewhat by including the exception type and using the standard exception formatting. The exception message still uses the same localization, not that it seems to apply often.
A later change should look into more user friendly errors for common issues, reserving the plain exception+trace display for the unexpected.