Use modern kotlin dsl build scripts instead of the groovy ones #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR, unfortunately this is something we have decided not to do for a wide range of reasons. Just becuase its the default for Gradle doesnt mean its the best choice for us. There is a PR here: FabricMC/fabricmc.net#23 to add an option to use Kotlin in the tempalte generator, however it needs a little bit of work to get it up to date. Thanks for the PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gradle the Kotlin dsl build scripts are the default instead of groovy. See https://blog.gradle.org/kotlin-dsl-is-now-the-default-for-new-gradle-builds.
Therefore the template should also use kotlin dsl.