Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous changes before updating to 1.21.3 #209

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

dicedpixels
Copy link
Contributor

@dicedpixels dicedpixels commented Oct 28, 2024

This PR addresses few issues and introduces some changes:

  • Updates Fabric API version 0.100.4+1.210.102.0+1.21
  • With above, fixes develop/events#adding-items-to-the-loot-table uses v2 instead of v3 #199 by using net.fabricmc.fabric.api.loot.v3.LootTableEvents and adds the registries parameter.
  • Fixes players/troubleshooting/crash-reports explains a crash report different to what it links to #189 by referring to the correct error line from the stack trace.
  • Attempted to fix issue 173 by providing a better explanation for tickDelta. Although, I'm not sure if we need to correct the usage here. Up for discussion.
  • Related to above:
    Renamed some usages of the word deltaTick with tickDelta to align with Yarn usages like RenderTickCounter#getTickDelta.
    Rename deltaTickManager and tickDeltaManager to tickCounter to align with the actual class name RenderTickCounter.
  • Potions guide had a code embed offset by one line, this PR fixes that as well.

@dicedpixels dicedpixels requested a review from a team as a code owner October 28, 2024 14:51
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 0f62e21
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/671fb2db93175000080a8190
😎 Deploy Preview https://deploy-preview-209--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@its-miroma its-miroma added correction Something isn't right on a page stage:verification This should be verified labels Oct 28, 2024
develop/rendering/hud.md Outdated Show resolved Hide resolved
reference/latest/build.gradle Show resolved Hide resolved
players/troubleshooting/crash-reports.md Outdated Show resolved Hide resolved
develop/rendering/basic-concepts.md Outdated Show resolved Hide resolved
develop/rendering/hud.md Outdated Show resolved Hide resolved
@its-miroma its-miroma merged commit ec8dcb2 into FabricMC:main Oct 28, 2024
7 checks passed
@its-miroma its-miroma added stage:ready This is ready to be merged and removed stage:verification This should be verified labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction Something isn't right on a page stage:ready This is ready to be merged
Projects
None yet
4 participants