Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more entries to gitignore #512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NebelNidas
Copy link
Member

Adds support for VS Code and Fleet, along with some Java debug files.

@modmuss50
Copy link
Member

I wonder if it would be worth moving it to a "git include" such as : https://github.com/FabricMC/fabric-loader/blob/master/.gitignore Otherwise we basically end up adding something for everyone.

I know some people dont really like these, but it seems to work quite well in my experience. Im happy to hear you ideas.

@NebelNidas
Copy link
Member Author

Seems like a more reasonable approach, I'd be fine with it 👍

@NebelNidas
Copy link
Member Author

After some fiddling around, it seems to be super annoying to set up though. There are a lot of edge cases one needs to consider, and the lack of a proper regex system doesn't help either

@2xsaiko
Copy link
Collaborator

2xsaiko commented Jun 16, 2023

IMO any personal IDE/build-related outputs (that isn't part of the repo such as Gradle) should go into your user gitignore anyway, ~/.config/git/ignore. As modmuss said, otherwise you'd be adding something for each IDE under the sun eventually, and especially you need to ignore your IDE files in each repo you're working on.

Exclude-by-default gitignore is also a nice solution, but personally I'd be very worried about accidentally missing new files in a commit because they're no longer listed as untracked in git status. Speaking from experience here (: But since most things are under src anyway, it's probably rare for that to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants