[WIP] Improve and extend mappings check command. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are these checks in the scope of this PR?
|
|
A check for the issues described in FabricMC/yarn#1145 would be nice |
liach
suggested changes
Jan 8, 2021
| @@ -0,0 +1,7 @@ | |||
| package cuchaz.enigma.command.checks; | |||
|
|
|||
| public class CheckFailureException extends RuntimeException { | |||
There was a problem hiding this comment.
I personally don't recommend overriding this. I see no point of this being an exception.
In fact, if the throwable/exception qualities are desirable, I suggest overriding fillInStackTrace to be no-op; otherwise the performance cost of creating exceptions are intensive, especially in loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is WIP, please suggest feedback and other possible checks. (Note this should not be checking yarn code styling, that would need to go else where, possibly by exposing the MappingCheck interface).
The package visablity checks have been made warnings as they shouldnt fail the build right now. I might expand the CLI to allow control over this.
Currently this PR adds checks for synthetic entries with names, and invalid entries. (Same as drop mappings)