Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fully mapped classes still report unmapped things in the Mappings Stats dialog #502

Open
PiTheGuy opened this issue Apr 29, 2023 · 3 comments

Comments

@PiTheGuy
Copy link

This mainly applies to enums, but I have found other cases.

Example: The following class reports 3 unmapped parameters
image

@jordanamr
Copy link

Can confirm, but it's probably because Enigma doesn't know if the unmapped enum is because of a misconfiguration or not, basically I think it doesn't know if it's... already unmapped or not ?

@NebelNidas
Copy link
Member

Probably because the enum's values and valueOf methods are technically still considered unmapped. But you can't rename them anyway, and the decompiler doesn't even show them

@PiTheGuy
Copy link
Author

PiTheGuy commented Sep 21, 2023

The methods it's counting that it shouldn't are Enum.values, Enum.valueOf, Enum.<init>, Record.equals, and Record.<init>.
Edit: It's actually only the first 2 parameters of Enum.<init>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants