Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some method parameters are incorrectly marked as mappable #207

Closed
PiTheGuy opened this issue Jun 23, 2024 · 2 comments · Fixed by #208
Closed

Some method parameters are incorrectly marked as mappable #207

PiTheGuy opened this issue Jun 23, 2024 · 2 comments · Fixed by #208
Labels
backend affects the enigma backend bug Something isn't working

Comments

@PiTheGuy
Copy link
Contributor

Consider the following class:
image
This shows as completely unmapped (0/4) on the side panel and reports 4 unmapped parameters in the stats tree,

After some investigation, I found the record's <init> and equals methods are considered unmapped and count towards the total, despite being unmappable and completely hidden from the user.

This is the same issue as FabricMC/Enigma#502 except it no longer affects enums.

@ix0rai ix0rai added bug Something isn't working backend affects the enigma backend labels Jun 23, 2024
@ix0rai
Copy link
Member

ix0rai commented Jun 24, 2024

I've started looking into this, and I'm still not sure why it happens. Next I need to set up a minimal reproduction case.

@ix0rai
Copy link
Member

ix0rai commented Jun 26, 2024

little update I'm trying to fix up records in general with this, as they're quite broken. fix will be delayed a while

@ix0rai ix0rai linked a pull request Sep 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend affects the enigma backend bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants