-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ep 294 correct values of alloc type(626) #40
Open
Ryno-Olivier
wants to merge
11
commits into
FIXTradingCommunity:master
Choose a base branch
from
Ryno-Olivier:EP-294-Correct-values-of-AllocType(626)
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ep 294 correct values of alloc type(626) #40
Ryno-Olivier
wants to merge
11
commits into
FIXTradingCommunity:master
from
Ryno-Olivier:EP-294-Correct-values-of-AllocType(626)
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"6" were added • Code set AllocTransTypeCodeSet(71): deprecated values “3”, “4”, “5”, "6" were missing. Nr 6 was not mentioned in the GAP E&O document but is visible in the FIXLatest version. So it was also added.
…issing Code set AllocTypeCodeSet(626): deprecated values “3”, “4, “6” were added according to the FIXLatest version.
AllocTransType(71)= "Value 6" has been removed.
…Set” Updated Field RefMsgType(372) to define type=“MsgTypeCodeSet” instead of “String”
…”, “5”, "6" were added" This reverts commit dca7ed4.
This reverts commit 74e1b0b.
…” were missing" This reverts commit 5f35612.
Code set AllocTransTypeCodeSet(71): deprecated values “3”, “4”, “5” were missing
Code set AllocTypeCodeSet(626): deprecated values “3”, “4, “6” were missing on FIX 4.4
kleihan
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIX Latest seems to have the wrong pedigree, needs to be fixed there first. Seems odd to add a field with 4.3 and deprecate it with an earlier version (4.2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code set AllocTypeCodeSet(626): deprecated values “3”, “4, “6” were missing on FIX 4.4