-
Notifications
You must be signed in to change notification settings - Fork 64
WIP list accepted talks/proposals #975
base: ep2019
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
def list_accepted_talks_for_current_conference(request): | ||
""" | ||
""" | ||
# Copy from conference/talk_vorting.py; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Copy from conference/talk_vorting.py; | |
# Copy from conference/talk_voting.py; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - one small comment that would help keep the codebase cleaner - I can help apply the changes.
Also, since it's a new view - could we add some xfailed tests for it?
""" | ||
""" | ||
# Copy from conference/talk_vorting.py; | ||
# Possibly could be refactored to use some function to come up with filters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have the same code in two files, this is definitely a candidate to be refactored.
No description provided.