Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

WIP list accepted talks/proposals #975

Open
wants to merge 1 commit into
base: ep2019
Choose a base branch
from

Conversation

artcz
Copy link
Contributor

@artcz artcz commented May 20, 2019

No description provided.

@artcz artcz requested a review from umgelurgel May 20, 2019 07:49
@artcz artcz self-assigned this May 20, 2019
Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

def list_accepted_talks_for_current_conference(request):
"""
"""
# Copy from conference/talk_vorting.py;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copy from conference/talk_vorting.py;
# Copy from conference/talk_voting.py;

Copy link
Contributor

@umgelurgel umgelurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one small comment that would help keep the codebase cleaner - I can help apply the changes.

Also, since it's a new view - could we add some xfailed tests for it?

"""
"""
# Copy from conference/talk_vorting.py;
# Possibly could be refactored to use some function to come up with filters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have the same code in two files, this is definitely a candidate to be refactored.

@umgelurgel umgelurgel changed the title list accepted talks/proposals WIP list accepted talks/proposals Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants