Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Firebase config and used better react-sketch library #22

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

tomdng
Copy link
Collaborator

@tomdng tomdng commented Mar 30, 2021

Description

Alright, so right now the production website is blank, even though everything works in dev. I dug around for an hour and realized that the reason this was happening was because the production version of the project actually crashed and had errors, hence the white screen. If you open up the console you can see any errors on production.

I ended up doing a bunch of stuff but in the end it came down to the fact that the react-sketch library was outdated and contained many bugs. See here and here for the two major issues I found with the library. The latter issue prevented it from working on Firefox specifically and the former issue prevented it from working on production.

The band-aid solution is to use a fork of react-sketch that's published on npm as 'react-sketch2'. See here for the forked project, which allows it to successfully build and run on my local machine. It turns out the original library built properly on my machine, but didn't run. Note that every version runs on the dev build, so you wouldn't notice any errors that way which was why production never matched what was on everyone's machines.

There also was in issue with our Firebase config (we didn't have an appId because you need to create an "app" on Firebase. I did that in the console and updated the config. Hopefully this one works!

@Erikpie Erikpie merged commit 1ab254d into main Mar 31, 2021
@tomdng tomdng deleted the feature/screen-share-demo branch April 1, 2021 02:06
@tomdng tomdng linked an issue Apr 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the tutor room creation and management logic
2 participants