Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schema validation for relgen #6345

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

josh-heyer
Copy link
Contributor

@josh-heyer josh-heyer commented Dec 12, 2024

What Changed?

This may not be the nicest way of handling errors, but it has the distinct advantages of allowing for in-editor warnings when using VSCode, which is nicer than dealing with error messages anyway.

also:

  • show warnings / errors in GitHub when running from Actions

  • allow running from npm

Reviewing

Pull locally, then from VSCode terminal run

npm i

then

npm run releasenotes:generate-all

Should have clickable links to non-compliant files with vaguely relevant line and column numbers. Click them, get reasonable-ish errors shown inline.

@josh-heyer josh-heyer requested a review from a team as a code owner December 12, 2024 03:50
also:

- show warnings / errors in GitHub when running from Actions

- allow running from npm
@josh-heyer josh-heyer force-pushed the automation/josh/validation-for-relgen branch from d9b8878 to 8bba8ca Compare December 12, 2024 03:58
@josh-heyer josh-heyer requested review from djw-m and removed request for a team December 12, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant