Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to PAS: DBMS_XMLDOMDOC corrections #6290 #6335

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

ebgitelman
Copy link
Contributor

What Changed?

@ebgitelman ebgitelman requested a review from a team as a code owner December 9, 2024 22:12

## Examples

This example executes a function named `func1` that creates the XML structure `<Deptartments>Dept1</Deptartments>` and returns the root node which is a `DOMDocument`.
This example executes a function `func1` that creates the XML structure `<Departments>Dept1</Departments>` and returns the root node, which is a `DOMDocument`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked to me like a typo, but please verify. It appears in several spots.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's definitely a typo. Thanks for spotting this!
I think we should probably do a search and replace to catch instances in code snippets. Unless you already did it? Let me know :)

@@ -2,7 +2,7 @@
title: "GETNODENAME"
---

The `GETNODENAME` function provides the name of the node depending on its type.
The `GETNODENAME` function provides the name of the node, depending on its type.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't really parse what "depending on its type" meant. Can you clarify this description? I think it needs elaboration. I wasn't sure if adding the comma was right.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make a DOMNode out of a DOMDocument, DOMElement, or DOMText. I think this means the GETNODENAME fetches the DOMNode name and also underlying type?

@nidhibhammar and @sravanvelag maybe you can help provide some clarity.

@@ -2,7 +2,7 @@
title: "GETNODEVALUE"
---

The `GETNODEVALUE` function provides the value of the node depending on its type.
The `GETNODEVALUE` function provides the value of the node, depending on its type.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same query here.

@ebgitelman
Copy link
Contributor Author

@nidhibhammar @gvasquezvargas I had a few queries on this. Also, look at the string XMLTYPE and XMLType in text and make sure the difference in capitalization is correct. I also donm't think it always needed to be tagged...did what I thought was right there but it could be wrong so please take a look. I don't think it's critical either way.

One other note, which is that we don't have any standard that says to use quote marks for elements as they were in various spots in this content. I believe the one place we do use it is when indicating char. These instances looked like they were meant to be just single quotes, i.e., appearing in computer font on screen.

@@ -12,11 +12,11 @@ GETNODENAME(n DOMNODE) RETURN VARCHAR2

`n`

`DOMNode` value to be provided.
`DOMNode` value to provide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this page related to GETNODENAME, I assume what this does is to fetch/display the value of a DOMNode?
@nidhibhammar @sravanvelag

Suggested change
`DOMNode` value to provide.
`DOMNode` value you want to obtain

@gvasquezvargas
Copy link
Contributor

I added some comments here and there, but let's wait for @nidhibhammar to chime in, as she has more experience with this product.

nidhibhammar and others added 7 commits December 10, 2024 09:38
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/getattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/getattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/getchildnodes.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/getfirstchild.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/setattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/setattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/setattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants