Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequences.mdx #6151

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update sequences.mdx #6151

wants to merge 4 commits into from

Conversation

matthew123987
Copy link
Contributor

What Changed?

@wind39

@matthew123987 matthew123987 requested a review from a team as a code owner October 14, 2024 16:48
@djw-m djw-m force-pushed the matthew123987-patch-2 branch from 3553c36 to bff5d56 Compare October 23, 2024 12:53
@@ -229,6 +230,9 @@ support renaming `galloc` sequences or moving them to another namespace or
renaming the namespace that contains a `galloc` sequence. Be
mindful of this limitation while designing application schema.

Additionally, after restoring a node from a backup, all galloc sequences must manually
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is correct.

Additionally, after restoring a node from a backup, all galloc sequences must manually have their next value set to the maximum value of the related column. See "Set a new start value for the sequence".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wind39 This is what you told me and what we did for the customer. please confirm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djw-m is correct. We didn't set the maximum value of the sequence to the maximum value of the column.

@matthew123987 , check your text: have their maximum value set to the maximum value of

It's a paste-o, well spotted by @djw-m .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wind39 have popped in my suggested text from above. Would be good to get a review and approval on this so we can merge (and push the changes into 5.6 content too, as that's the new latest branch).

@djw-m djw-m force-pushed the matthew123987-patch-2 branch from 2159476 to 22286b2 Compare October 29, 2024 12:19
@djw-m djw-m added the deploy Add this label to a PR and it will automatically be deployed to netlify label Oct 29, 2024
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants