-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: switch npm to yarn and resolve vulnerabilities #1827
base: production
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit ee6979b): https://emeris-app--pr1827-build-move-npm-to-ya-r5ludcud.web.app (expires Mon, 13 Jun 2022 10:37:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Nice idea! Code wise LGTM 💃🏼 Let's see what others say 💜 |
Not in support of the switch but don't feel too strongly about it (It'll be fine if we do). Can't we just use overrides? 'overrides' is only available in version 8.x. |
This reverts commit c549f2c.
overrides in my experience don't work that well @pranaybaldev. Do you have good experiences with them? |
I also don't feel strongly about switching, however I remember @clockworkgr expressing that using npm made debugging easier. I'll be more comfortable with the PR with Alex's blessing |
Hi folks 👋
We have discussed before whether to switch from NPM to Yarn, and we ended up not switching, because NPM was generally easier to debug.
Hereby I still make the suggestion to switch, because:
The following actually resolves the axios dependency.
We could directly ask ignite frontend team to update starport/vuex to update dependency @confio/relayer . That would fix it in a better way, but this is a temporary fix: