Update how global variables are matched #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated how code was removed from within brackets. Previous method did not work well with nested brackets. Added match for global pointers Added match for global sized array where size is from #define Updated how line number match worked for special cases
|
I found a few other false global variables, so I pushed some additional code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised how many global variables this found in the codebase I'm working in, so I looked into it. Turns out some of the globals it found weren't actually globals, and it missed some actual globals.
I added test cases for the 4 types of missing or false globals I found, then updated the code to pass the tests.