address dual dts issues #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 505b9b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
patroza
force-pushed
the
b/fix-dual-dts-issue
branch
from
16a43c1
to
a1e2221
Compare
fubhy
requested changes
Mar 27, 2024
Co-authored-by: Sebastian Lorenz <[email protected]>
Andarist
reviewed
Mar 27, 2024
| Effect.all([ | ||
| fs.writeFileString( | ||
| `dist/dist/cjs/${module}.d.ts`, | ||
| `export * from "../dts/${module}"`, |
There was a problem hiding this comment.
u could very well just do this to be more explicit:
Suggested change
| `export * from "../dts/${module}"`, | |
| `export * from "../dts/${module}.js"`, |
the .js extension isn't forbidden in CJS-oriented .d.ts files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found the structural fix for the dual dts problem, exposed for example when you start using
fast-checkwith schema from an esm project.The problem appears to stem from that a single dts file exposed from package.json can only be interpeted either as cjs or as esm, which will dictate which dts it will load from external packages, which for better or worse, can have different .d.ts files for esm and cjs.
In the case of schema that turns out to be the cjs version of fast-check, leading to the problem once you mix it from an esm source.
The fix is by creating individual proxy .d.ts for cjs and esm, but re-exporting from a single source of dts truth, so that symbols remain unique