Autocomplete loadout hashtags in loadout drawer #8918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
force-pushed
the
loadout-hashtags-autocomplete
branch
from
2fe9eb4 to
b4be32a
Compare
|
So Would be good to test this in other browsers though. |
|
Hmm - we used to use this for autocomplete in the main search bar, which was a regular text input. But maybe that was a previous version of the library. |
bhollis
reviewed
Jan 7, 2023
| if (textArea.current) { | ||
| // commit a type crime here because textcomplete says it only works with | ||
| // TextArea but happens to also work entirely fine with Input[type=text] | ||
| const editor = new TextareaEditor(textArea.current as unknown as HTMLTextAreaElement); |
There was a problem hiding this comment.
Sub to yuku/textcomplete#355
robojumper
force-pushed
the
loadout-hashtags-autocomplete
branch
from
16bdb7f to
1796fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #8916. The textcomplete package doesn't support
<input />out of the box, but the code basically works fine even when the types don't say it, so a cast makes it work.