This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Enrich android play store upload #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 12, 2019 15:15
davetao
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
@timmutton thanks for fixing the Kotlin issues that we had earlier.
dotb
suggested changes
May 2, 2019
| @@ -19,5 +18,6 @@ private AndroidPropConstants() { | |||
| public static final String BUILD_PROP_HOCKEYAPP_TOKEN = "hockappToken"; | |||
| public static final String BUILD_PROP_HOCKEYAPP_RELEASE_TAGS = "hockeyappReleaseTags"; | |||
| public static final String BUILD_PROP_HOCKEYAPP_RELEASE_NOTES = "hockeyappReleaseNotes"; | |||
| public static final String BUILD_PROP_FILENAME_FILTERS = "fileNameFilters"; | |||
There was a problem hiding this comment.
Hey @timmutton , do you mind adding some documentation for the new fileNameFilters parameter on the Github wiki and example config file?
| @@ -29,6 +29,8 @@ public void performTask(BuildEnvironment buildEnvironment) throws TaskFailedExce | |||
| String scheme = buildEnvironment.getProperty(BUILD_PROP_SCHEME); | |||
| String keystorePath = buildEnvironment.getProperty(BUILD_PROP_JAVA_KEYSTORE_PATH); | |||
| String storePass = buildEnvironment.getProperty(BUILD_PROP_STOREPASS); | |||
|
|
|||
| // TODO: these are likely to be incorrect | |||
There was a problem hiding this comment.
Do we need to clean this one up before we merge?
There was a problem hiding this comment.
should be a separate fix, this is just something while i was digging around
added 3 commits
May 10, 2019 13:12
…loitteDigitalAPAC/readyci into tech/enrich_android_play_store_upload
|
@dotb i honestly dont remember why I put the libs there, but ive removed them and everything seems to work |
added 2 commits
May 10, 2019 13:18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating whether we can derive the output filename from the assemble task, submitting this in case it doesnt work out or I get pulled away.
Some of the logic from the play store uploaded ended up in the hockey app upload